a bit refactoring and fixed timeline UI spacing #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scribblemaniac
requested changes
Apr 25, 2017
core_lib/interface/timecontrols.cpp
Outdated
| QIcon endplayIcon(":icons/controls/endplay.png"); | ||
| QIcon startplayIcon(":icons/controls/startplay.png"); | ||
| QIcon JumpToEndButton(":icons/controls/endplay.png"); | ||
| QIcon JumpToStartButton(":icons/controls/startplay.png"); |
Member
There was a problem hiding this comment.
Can you rename these variables to start with a lowercase letters to keep the naming styles consistent?
scribblemaniac
approved these changes
Apr 25, 2017
|
Hi @candyface I just subscribed here to tell you how much we all appreciate what you have been done lately. Thank you! Helping @chchwy will allow him to follow his/our dream about having Pencil2D fully workable in a faster rate. By the way, you may close (not sure if you are in charge here) issue #38 (you have just done what I asked in 2013 👍 ) Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the gaps in the timeline UI and refactored a bit on the timeline UI code.