Install .cms files alongside .cmt files #5005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hacky way of generating and then installing the
.cmsfiles for the compiler alongside the.cmtfiles. As a result, a subset of the.cmsfiles will subsequently be picked up by the per-file format metrics. Currently, there are 797.cmtfiles that we install, but this PR only adds 352.cmsfiles. See the considerations below.Considerations
.cmsfiles are generated and installed unconditionally at the moment. The size of all of the 352 files is currently ~4 MB. For comparison, the 797.cmtfiles are currently ~376 MB..cmsfiles, dune would have to support-bin-annot-cms. Even with the current hack, there are many.cmtfiles that don't have corresponding.cmsfiles as noted above..cmsfiles rather than the.cmtfiles from the installation.