Use runtime functions for Sys consts in JSIR #4566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oxcaml into selee.jsir-translate-control-flow
mshinwell
approved these changes
Aug 22, 2025
Collaborator
mshinwell
left a comment
There was a problem hiding this comment.
OK to merge after some minor fixes
middle_end/flambda2/from_lambda/lambda_to_flambda_primitives.ml
Outdated
Show resolved
Hide resolved
Base automatically changed from
selee.jsir-use-bytecode-c-functions
to
selee.jsir-from-flambda2
September 3, 2025 14:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the lambda -> flambda pass transformed them into constants based on the host compiler settings - now we call the runtime functions provided by jsoo.