Use 32-bit int types for ocamlj #4558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oxcaml into selee.jsir-external-functions
… selee.jsir-targetint-actually-32
…oxcaml into selee.jsir-external-functions
…oxcaml into selee.jsir-external-functions
jvanburen
approved these changes
Aug 25, 2025
Base automatically changed from
selee.jsir-debug
to
selee.jsir-from-flambda2
September 2, 2025 22:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
Targetint_31_63assumed that ocaml ints in javascript are 31-bits wide; it's actually 32. We use the same unfortunate hack as inTargetint_32_64to detect that we are runningocamlj, and switch to 32 bits instead. Note thatTargetint_31_63was renamed toTarget_ocaml_intin themainbranch in anticipation of this change, so the module name beingTargetint_31_63is not a problem - it will be resolved post-rebase.