Jsoo iarray repatch #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! I'm not sure what's happening either, since jsoo installed just fine in the CI. |
Collaborator
|
Update: we finally figured out the issue. This was caused by recent opam versions switching to a stricter patch validation logic than GNU patch. We now use the same logic in our publishing code, so we won't have to worry about this error anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would seem something like #11 has happened again? I'm not exactly sure where this is stemming from, maybe a mismatch in the commit the js_of_ocaml is pointing too? I did a best effort at finding the right place in the jsoo file that the patch seemed to be applied too :))