Enforce let-punning in the janestreet profile #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccasin
reviewed
May 24, 2024
ccasin
left a comment
There was a problem hiding this comment.
I read this and it looks fine to me (modulo questions below). But I'm going to hold off on approving until we've had a chance to test it on the tree because we could easily be missing some corner case.
ccasin
approved these changes
May 28, 2024
ccasin
left a comment
There was a problem hiding this comment.
Approved, but will let David merge when he's ready.
rewrite [let%foo bar = bar in ...] to [let%foo bar in] whenever possible includes tests for comments and some corner cases where it is better not to pun Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
d54c9a3 to
28556e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever it is possible to "pun" a
let-binding, do so.We do this for any
letbinding that is an extension or an operator and where the LHS and RHS are just the same identifier (no attached attributes, no type annotations).I've added tests for a few tricky cases to
let_punning.ml. I've also tested internally, and our styler runs without producing any syntax errors. More thorough testing will need to wait for the parser fix in compiler PR #2612.