remove the nonlocal_ modality
#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20fc17b to
4005488
Compare
ccasin
approved these changes
Jun 14, 2023
ccasin
left a comment
There was a problem hiding this comment.
Looks good.
Will hold off on merging until the relevant compiler has been released.
Signed-off-by: Zesen Qian <github@riaqn.org>
4005488 to
d5d4f48
Compare
Signed-off-by: Zesen Qian <github@riaqn.org>
Signed-off-by: Zesen Qian <github@riaqn.org>
mdelvecchio-jsc
pushed a commit
that referenced
this pull request
Jul 20, 2023
* remove nonlocal_ Signed-off-by: Zesen Qian <github@riaqn.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding to oxcaml/oxcaml#1452 , this PR removes the support for the
nonlocal_modality in ocamlformat.Kindly request review from @ccasin