support exclave_ syntax #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e71cc0 to
03d5237
Compare
03d5237 to
24fbf13
Compare
|
I will review this, but @riaqn is going to make a couple tweaks first. |
Signed-off-by: Zesen Qian <github@riaqn.org>
24fbf13 to
f885ebb
Compare
Author
|
@ccasin I think it's ready for review now 😄 |
ccasin
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Looks good!
I will hold off on merging and let @ceastlund and friends do that when they want. Carl: This supports a feature that will be in the next compiler release. I will ping you when it makes sense to roll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As subject - corresponds to oxcaml/oxcaml#1338