这是indexloc提供的服务，不要输入任何密码
Skip to content

add support for global/nonlocal constructor arguments #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

add support for global/nonlocal constructor arguments #17

merged 1 commit into from
Apr 19, 2023

Conversation

@riaqn
Copy link

@riaqn riaqn commented Apr 17, 2023

This PR adds the support for global_ and nonlocal_ constructor arguments. An example:

type 'a r =
  | Foo of global_ 'a
  | Bar of nonlocal_ 'a * global_ 'a
  | Baz of global_ int * nonlocal_ string * global_ 'a

@riaqn
add support for global/nonlocal constructor arguments
750ebab 
Signed-off-by: Zesen Qian <github@riaqn.org>
@riaqn riaqn force-pushed the global-construct-new branch from fdfdc05 to 750ebab Compare April 17, 2023 13:17
@ccasin ccasin self-requested a review April 18, 2023 16:01
ccasin
ccasin approved these changes Apr 18, 2023
View reviewed changes
Copy link

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but let's coordinate with sprucedev before hitting merge - I'll write an email).

@mdelvecchio-jsc mdelvecchio-jsc merged commit 44f03ca into oxcaml:jane Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccasin ccasin ccasin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@riaqn @ccasin @mdelvecchio-jsc