Format comments #123
Merged
Format comments #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa79aea to
502c864
Compare
mdelvecchio-jsc
requested changes
Nov 3, 2025
mdelvecchio-jsc
left a comment
There was a problem hiding this comment.
Review of PR for now, gonna look at offline diff.
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
502c864 to
2ab7a2b
Compare
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
added lists for numbers only; letters are likely to be code, I think Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
[1] at start of line specifically Signed-off-by: David Vulakh <dvulakh@janestreet.com>
mdelvecchio-jsc
approved these changes
Nov 6, 2025
mdelvecchio-jsc
left a comment
There was a problem hiding this comment.
I think all of the remaining work is freezing bad comments, the diff looks great though.
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch on formatting for remaining (non-doc) comments.
We conservatively do not format single-line comments whose contents might be code with whitespace-dependent semantics or that may otherwise experience semantic changes upon formatting (namely, comments that contain
",{, or}).See updated tests.