Fix jkind normalization #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelvecchio-jsc
approved these changes
Nov 3, 2025
| @@ -0,0 +1,5 @@ | |||
| (* This is just here so that the std ast normalization fails and we are reliant on the | |||
| extended ast *) | |||
Author
There was a problem hiding this comment.
Replaced with a test that is probably comparably hacky, but should be less brittle.
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the hacked AST-preservation check, we've been subtly hiding two bugs in jkind normalization in the extended AST:
[@@immediate]is rewritten to: immediateduring formatting (and not parsing), and the two are not normalized to the same syntax by the extended parsetree normalizer.The two bugs become more pernicious in the child PR, where the extended AST is alone responsible for normalization of formatted code in comments. Quite a few of our comments involve kind annotations (either exlicitly or as attributes), so I decided to fix.
As a side effect of fixing the mapper, comment association in complex jkinds improves.
Review by commit.