Block indices #120
Merged
Block indices #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
involved hacking around the broken state of the metaprogramming syntax Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
tests from compiler pass Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
this mostly is a clone of upstream pr 2680; also fixes all the tests ocaml-ppx#2680 Signed-off-by: David Vulakh <dvulakh@janestreet.com>
pulls in changes from oxcaml#4691 Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
ccasin
approved these changes
Oct 10, 2025
ccasin
left a comment
There was a problem hiding this comment.
Eagerly approving, but I think I spotted one bug - see comments
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for block indices, introduced in oxcaml#4017.
Importing the parser changes up until this point also picks up what looks like half-finished metaprogramming syntax/parsing. Full support, including for gating the special meaning of
$, is forthcoming (some of it is already in the compiler in commits that postdate oxcaml#4017). This PR does not make an effort to handle any such changes, but does leave most of the imported code in the files (even if sometimes commented out) to make future runs of the parser import script clearer.Consider reviewing by commit.