Fix parens on array literals when used as function arguments #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Casinghino <ccasinghino@janestreet.com>
antalsz
added a commit
to antalsz/ocamlformat
that referenced
this pull request
Feb 10, 2023
antalsz
added a commit
to antalsz/ocamlformat
that referenced
this pull request
Feb 10, 2023
antalsz
added a commit
to antalsz/ocamlformat
that referenced
this pull request
Feb 15, 2023
antalsz
added a commit
to antalsz/ocamlformat
that referenced
this pull request
Feb 15, 2023
Signed-off-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
ceastlund
pushed a commit
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Antal Spector-Zabusky <antal.b.sz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antal pointed out that:
is being misformatted as
This PR fixes that. There are changes in two files (plus a test):
Fmt_ast, the result ofparenze_expwas being ignored for array literals. Now it isn't.Ast, theparenze_expfunction was saying that array literals should be parenthesized too often, but this went unnoticed because its result was being ignored inFmt_ast. Now it follows the same rules used for list literals.This is an upstream bug. I'll submit a PR there too.