Fix bug with formatting layout annotations #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldfirere
approved these changes
May 16, 2024
32f7c6e to
60b6ba1
Compare
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Co-authored-by: Richard Eisenberg <rae@richarde.dev> Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
97d0f1a to
1cc96f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #65 introduced a bug with formatting layout annotations. A small example of a file that would fail to format is
The testsuite did not catch this bug due to the the fact that the only layout annotation test was an already formatted file.
This PR fixes the bug and updates the test to check for this in the future. It also re-enables the windows build, since this was apparently also the bug causing that to fail.