Remove extensions.ml from parser-extended
#67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2024 11:41
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
0ba4d72 to
b14475b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now add syntax extensions directly to the parsetree in
parser-extended, but historically we have usedextensions.mlto do things like this. It's a bit annoying to still haveextensions.mlaround, so this PR moves all the syntax from there into the parsetree proper and then deletes the file.Just a refactor, no behavior changed (besides the debugging output from
Extended_ast.Printast)