Parse any layout name, not just a preset list #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
goldfirere
reviewed
May 3, 2024
goldfirere
left a comment
There was a problem hiding this comment.
Looks good. It's worth adding a few tests.
added 2 commits
May 3, 2024 18:13
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
freemagma
added a commit
to freemagma/ocamlformat
that referenced
this pull request
May 17, 2024
* passes tests Signed-off-by: Charlie Gunn <cgunn@janestreet.com> * changed name of the type back to [const_layout] Signed-off-by: Charlie Gunn <cgunn@janestreet.com> * added some tests Signed-off-by: Charlie Gunn <cgunn@janestreet.com> --------- Signed-off-by: Charlie Gunn <cgunn@janestreet.com> Co-authored-by: Charlie Gunn <cgunn@janestreet.com> Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates both
parser-standardandparser-extendedto be able to parse any string as a layout name. This puts them in line with the behavior of theflambda-backendcompiler's parser.