Small typo fix (campl-streams -> camlp-streams) #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Rodriguez <enoumy@gmail.com>
b9d42d7 to
6f73b7f
Compare
Author
|
Signed-off-by: Jose Rodriguez enoumy@gmail.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While following the opam install instructions while trying to run
make test, I saw the following error:This small feature fixes what I think is a typo from
campl-streams->camlp-streamsin the installation instructions.Testing.
I ran
make testand will additionally wait for any CI to complete before opening this pr up for review. Please let me know if there is additional testing that I should perform. Thanks!I additionally saw a DCO check that failed due to me not originally putting:
on my commit. I then ran
git rebase -i janeand then reworded the commit the single commit in this feature to include the message, but this still resulted in CI failure. I then manually hit the button called "Set DCO to pass". I am unsure if this is the "proper" way of making the DCO check pass. Please let me know otherwise.