这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix parenthesization of labeled tuple patterns #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix parenthesization of labeled tuple patterns #54

merged 2 commits into from
Jan 9, 2024

Conversation

@ccasin
Copy link

@ccasin ccasin commented Jan 9, 2024 •
edited
Loading

The previous version would attempt to format:

let foo x =
  match x with
  | ~a:(Some _), ~b -> false
  | _ -> true

as

let foo x =
  match x with
  | ~a:Some _, ~b -> false
  | _ -> true

The parens are required by the parser, so the updated version doesn't parse, causing ocamlformat to blow up.

ncik-roberts
ncik-roberts approved these changes Jan 9, 2024
View reviewed changes
Copy link

@ncik-roberts ncik-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The logic makes sense.
  • The test case looks good.

I don't know ocamlformat's codebase very well at all, but I think this change looks good.

@ccasin ccasin merged commit b978f42 into oxcaml:jane Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncik-roberts ncik-roberts ncik-roberts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccasin @ncik-roberts