Restore diagnostics and formatting #4
Conversation
| (odoc :with-doc) | ||
| (odoc-parser (= 2.0.0)) | ||
| (merlin-lib (= "5.2.1-502+jst")) | ||
| (merlin-lib (= "5.2.1-502+ox")) |
There was a problem hiding this comment.
This corresponds to the published version on the OxCaml opam-repository, but there might be some broader changes needed to support that
| } | ||
| ; syntax_documentation = Some { enable = false } | ||
| ; merlin_diagnostics = Some { enable = false } | ||
| ; merlin_diagnostics = Some { enable = true } |
There was a problem hiding this comment.
Configuration of this setting isn't possible in many LSP clients (e.g. the ocaml-platform VS Code extension), and defaulting to true seems to match the previous behaviour. I guess the false default might make sense in the JS internal toolchain
| ~referencesProvider:(`Bool true) | ||
| ~documentHighlightProvider:(`Bool true) | ||
| ~documentFormattingProvider:(`Bool false) | ||
| ~documentFormattingProvider:(`Bool true) |
There was a problem hiding this comment.
As above, this probably makes sense in the JS internal toolchain but isn't configurable by clients. Editor formatting (via the LSP) does work as expected (with version unset in .ocamlformat) with this capability enabled
|
|
||
| let exec cancel bin args stdin = | ||
| let refmt = Fpath.to_string bin in | ||
| let refmt = Stdune.Path.to_string bin in |
There was a problem hiding this comment.
This change might not strictly be needed
|
This was just brought to my attention. The merlin_diagnostics setting should probably default to true; this was an oversight, since our editors provide that setting internally. @sam-tombury: is there a reason you closed the request? |
No description provided.