这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@liam923
Copy link
Contributor

@liam923 liam923 commented Nov 11, 2025

There's been reports of syntax documentation sometimes spuriously showing hints about [@nontail] attributes. It turns out this was due to a ppx generating [@nontail] attributes whose location was ghost but encloses the cursor. The fix here is easy - we shouldn't be displaying syntax doc hints about nodes that are ghost.

Unforunately this is a difficult PR to write a test for. Writing a test would involve writing a ppx that generates ghost nodes, which would be a substantial amount of effort (partially because we wouldn't have ppxlib at our disposal to do so). Rather, I performed manual testing to verify that this fixes the reported errors.

@liam923 liam923 merged commit 3d3013f into main Nov 11, 2025
1 check passed
@liam923 liam923 deleted the filter-ghost-from-syntax-doc branch November 11, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants