Fix flaky tests #166
Merged
Fix flaky tests #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for parameterized libs (
tests/test-dirs/parameters.t) have been flaky. Presumably this is because they use the merlin server, and multiple tests that use the Merlin server running concurrently can cause unexpected behavior. There is prior art to dealing with this - dune locks, as seen intests/test-dirs/server-tests/dune. This PR makes theparameters.ttest take out themerlin_serverlock.Locally on my computer, I have been able to reliably trigger a test failure when building and running tests from a clean repo. After this change, I have not triggered the error (n=4), so I am fairly confident that this change fixes the issue.