Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit non-standard because I did the import in two phases. ie, I ran imported changes at some revision in between minus11 and minus12, and then imported the changes at minus12. As a result, it's probably best to review in two phases: the conflict resolution from the first merge, and then the conflict resolution from the second merge.
The first two commits, cbeeb72 and 5580042, are the result of running the import script and should be skipped. Commits 4153ae7 and a776534 correspond to the second running of the import script and should also be skipped. So here's my overall review recommendation:
Both merges were pretty straightforward, but there's a couple things worth commenting on:
tests/test-dirs/parameters.t/run.t). @lukemaurer is aware of this but doesn't currently have bandwidth to resolve the issue. But parameterized libraries aren't yet widely used and the regression is minor, so it's okay to merge with this regression.cmt_format.mlregardingrecord_declaration_dependency. I discussed this with @voodoos on a draft PR in this comment thread: Merge compiler renaming changes #150 (comment)