这是indexloc提供的服务，不要输入任何密码
Skip to content

Move typed_hole from ocaml-lsp #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Move typed_hole from ocaml-lsp #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87d4877
Move typed_hole from ocaml-lsp
liam923 Jan 17, 2025
9cb4d25
Format
liam923 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/analysis/typed_hole.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
let syntax_repr = "_"
let can_be_hole s = String.equal syntax_repr s

(* the pattern matching below is taken and modified (minimally, to adapt the
return type) from [Query_commands.dispatch]'s [Construct] branch;

If we directly dispatched [Construct] command to merlin, we'd be doing
useless computations: we need info whether the expression at the cursor is a
hole, we don't need constructed expressions yet.

Ideally, merlin should return a callback [option], which is [Some] when the
context is applicable. *)
let is_a_hole = function
| (_, Browse_raw.Module_expr { mod_desc = Tmod_typed_hole; _ }) :: (_, _) :: _
| (_, Browse_raw.Expression { exp_desc = Texp_typed_hole; _ }) :: _ -> true
| [] | (_, _) :: _ -> false
15 changes: 15 additions & 0 deletions src/analysis/typed_hole.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
(** This module should be used to work with typed holes. The main goal is to
hide syntactic representation of a typed hole, which may change in future *)

(** checks whether the current string matches the syntax representation of a
typed hole *)
val can_be_hole : string -> bool

(** [is_a_hole nodes] checks whether the leaf node [1] is a typed hole

Note: this function is extracted from merlin sources handling [Construct]
command in [merlin/src/frontend/query_commands.ml]

[1] leaf node is the head of the list, as
[Mbrowse.t = (Env.t * Browse_raw.node) list]*)
val is_a_hole : Mbrowse.t -> bool
Loading