Improve stale occurrences #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As discussed in person, @liam923 will explore the possibility of getting a review from Ulysse, who is more expert in this code. If there is somehow trouble, please call me back into service here. |
Contributor
Author
|
I've opened a PR upstream: ocaml/merlin#1885 |
Contributor
Author
|
The upstream PR has now been reviewed and merged. All that's left to do now is verify that this is a correct backport of that PR. @goldfirere |
afcb166 to
7072ee8
Compare
goldfirere
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Merlin finds project-wide occurrences, it loads lists of occurrences from index files. Those index files contain metadata about the state of the ml/mli files when the index was generated. This is used as a heuristic to determine if occurrences might be stale (ie, that occurrence was either moved or removed since the index file was generated).
This PR does two things:
The net effect for an end user should be nothing - the stale occurrences should still be reported by their editor. But this enables future LSP/editor work.