Move more types to query_protocol_kernel
#149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compl.kind and Locate_context.t in query_protocol_kernelquery_protocol_kernel
e46b24b to
17cd8de
Compare
ba8a21f to
f563acf
Compare
Contributor
Author
|
Closing this PR for the same reasons as in ocaml/merlin#1952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use these types in a vscode extension, so this pr moves them to a jsoo-compatible library. I'm also using this feature as a trojan horse for two minor changes:
ppx_string_convandppx_enumerateforLocate_context.`Keywords(of the typeCompl.kind) doesn't round trip. This PR makes it round trip by addingkeywordsas a valid input string. (This doesn't actually seem to be important for anything - I just happened to notice it.)Note: This PR is based on
locate-type-multi, notmain.