Add script to update magic numbers #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam923
commented
Oct 16, 2024
| let index_magic_number = "Merl2023I501" | ||
|
|
||
| let interface_suffix = ref ".mli" | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The changes in this file are meant to make the script a bit simpler - there's no material changes
Contributor
ncik-roberts
left a comment
There was a problem hiding this comment.
Running the script produces a diff for me:
-let index_magic_number = "Merl2023I501"
+let index_magic_number = "Merl2023I551"
ncik-roberts
approved these changes
Oct 16, 2024
Contributor
ncik-roberts
left a comment
There was a problem hiding this comment.
That change is expected, according to Liam.
dkalinichenko-js
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Add script to update magic numbers * Fix CI failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new script that will bump the magic numbers.
Running this script will:
src/ocaml/utils/config.mlsrc/ocaml/typing/magic_numbers.mlA test run of this script can be done by:
551with552inupstream/ocaml_flambda/configure../update-magic-numbers.sh 5.2.0minus-2I've performed a few test runs of this script, where:
src/ocaml/typing/magic_numbers.mlupstream/ocaml_flambda/configureare not the expected formatsrc/ocaml/utils/config.mlthat the script doesn't know about