Avoid hidden dependencies with short-paths #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldfirere
approved these changes
Sep 30, 2024
lpw25
reviewed
Oct 1, 2024
src/ocaml/typing/short_paths.ml
Outdated
| depends : string list; | ||
| alias_depends : string list; | ||
| desc : Desc.Module.t; | ||
| visibility : Desc.module_visibility; |
Contributor
There was a problem hiding this comment.
Do you actually need to add a new field to be threaded around here? IIRC the only effect of the deprecated field is to treat the module as hidden. Perhaps you could just rename the deprecated field to visibility instead?
Contributor
Author
There was a problem hiding this comment.
I suppose not. I left it in to make it easier if we ever want to do something different. But that would be easy to undo, so I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short-paths currently doesn't understand hidden dependencies. This PR makes short-paths prefer a module path that does not rely on a hidden dependency over one with a hidden dependency, even if it is longer.