WIP - feat: implment no-unnecessary-condition rules #389
+4,226
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `no-unnecessary-condition` rule to the linter, which detects unnecessary conditional expressions in TypeScript code. The rule is implemented in `no_unnecessary_condition.go` and is accompanied by comprehensive tests in `no_unnecessary_condition_test.go`. The rule checks for always truthy or falsy conditions, unnecessary optional chaining, and allows configuration for constant loop conditions.
This commit expands the `no-unnecessary-condition` rule by adding new checks for unnecessary conditions, including handling of the `never` type, literal comparisons, and type overlap in equality operations. It also introduces new messages for specific cases, improving the rule's ability to detect unnecessary conditional expressions in TypeScript code. Comprehensive tests have been updated to cover these new scenarios.
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
Author
|
256/293 (87.4%) |
Contributor
Author
|
Current Status: 263/294 tests passing (89.5%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #188
234/293 (79.9%)