这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented May 29, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented May 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented May 29, 2024

@Dunqing Dunqing marked this pull request as ready for review May 29, 2024 03:43
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label May 29, 2024
@Dunqing Dunqing requested a review from Boshen May 29, 2024 03:45
@codspeed-hq
Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #3460 will not alter performance

Comparing 05-29-fix_transformer_typescript_variable_declarations_are_not_created_when_a_function_has_a_binding_with_the_same_name (b4fd1ad) with main (90b0f6d)

Summary

✅ 22 untouched benchmarks

@Dunqing Dunqing force-pushed the 05-29-refactor_typescript_namespace_reuse_tsmoduleblock_s_scope_id branch from 5d3dc7f to 1417f2a Compare May 29, 2024 13:32
@Dunqing Dunqing force-pushed the 05-29-fix_transformer_typescript_variable_declarations_are_not_created_when_a_function_has_a_binding_with_the_same_name branch from c306e73 to 5266a7f Compare May 29, 2024 13:32
@overlookmotel
Copy link
Member

I don't understand TS namespaces well enough to properly review this. But the test passes, so I say merge it!

@graphite-app
Copy link
Contributor

graphite-app bot commented May 29, 2024

Merge activity

@Dunqing Dunqing force-pushed the 05-29-refactor_typescript_namespace_reuse_tsmoduleblock_s_scope_id branch from 1417f2a to d599902 Compare May 29, 2024 22:55
Dunqing added a commit that referenced this pull request May 29, 2024
…en a function has a binding with the same name (#3460)
@Dunqing Dunqing force-pushed the 05-29-fix_transformer_typescript_variable_declarations_are_not_created_when_a_function_has_a_binding_with_the_same_name branch from 5266a7f to d426c74 Compare May 29, 2024 22:56
@Dunqing Dunqing force-pushed the 05-29-refactor_typescript_namespace_reuse_tsmoduleblock_s_scope_id branch from d599902 to 04628ab Compare May 29, 2024 22:58
@Dunqing Dunqing force-pushed the 05-29-fix_transformer_typescript_variable_declarations_are_not_created_when_a_function_has_a_binding_with_the_same_name branch from d426c74 to d2d4381 Compare May 29, 2024 22:58
…en a function has a binding with the same name (#3460)
@Dunqing Dunqing force-pushed the 05-29-refactor_typescript_namespace_reuse_tsmoduleblock_s_scope_id branch from 04628ab to 1a50b86 Compare May 29, 2024 23:00
@Dunqing Dunqing force-pushed the 05-29-fix_transformer_typescript_variable_declarations_are_not_created_when_a_function_has_a_binding_with_the_same_name branch from d2d4381 to b4fd1ad Compare May 29, 2024 23:01
@Dunqing Dunqing changed the base branch from 05-29-refactor_typescript_namespace_reuse_tsmoduleblock_s_scope_id to main May 29, 2024 23:05
@graphite-app graphite-app bot merged commit b4fd1ad into main May 29, 2024
@graphite-app graphite-app bot deleted the 05-29-fix_transformer_typescript_variable_declarations_are_not_created_when_a_function_has_a_binding_with_the_same_name branch May 29, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants