feat: add yarn_pnp logic to FileSystem
#589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running fs operations through yarn_pnp incurs significant performance cost, caused by running `VPath::from(path)` on every path. Feature gate this through a runtime flag, because a bundler can enable `yarn_pnp` feature but run the resolver without presence of `yarn`.
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 12 12
Lines 2719 2721 +2
=======================================
+ Hits 2584 2586 +2
Misses 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #589 will not alter performanceComparing Summary
|
This was referenced Jul 4, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running fs operations through yarn pnp incurs significant performance cost, caused by running
VPath::from(path)on every path.Feature gate this through a runtime flag,
because a bundler can enable
yarn_pnpfeature but run the resolver without presence ofyarn.