feat(napi): upgrade NAPI-RS to 3.0.0-beta.1 #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades NAPI-RS dependencies to the 3.0.0-beta.1 release, aligning the Rust and JavaScript-side versions. Key changes include:
- Updating dependency versions in package.json and Cargo.toml.
- Reordering and updating module exports in resolver files.
- Adjusting import statements and exports for consistency.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated "@napi-rs/cli" version (note: still alpha version) |
| napi/resolver.wasi.cjs | Reordered destructured imports and updated module exports |
| napi/resolver.wasi-browser.js | Modified import order and added default export for module exports |
| napi/index.js | Adjusted module exports with minimal formatting changes |
| napi/Cargo.toml | Upgraded "napi", "napi-derive", and "napi-build" dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
package.json:30
- The Cargo.toml dependencies have been updated to '3.0.0-beta.1', yet '@napi-rs/cli' in package.json remains at an alpha version. Consider verifying if this version should also be updated for consistency across the project.
"@napi-rs/cli": "3.0.0-alpha.79",
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 13 13
Lines 2829 2829
=======================================
Hits 2655 2655
Misses 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #525 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.