throw recursion error when resolving cursed browser fields #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 94.09% 94.11% +0.01%
==========================================
Files 11 11
Lines 2253 2259 +6
==========================================
+ Hits 2120 2126 +6
Misses 133 133 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #17 will not alter performanceFalling back to comparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From webpack test suite: https://github.com/webpack/webpack/blob/87660921808566ef3b8796f8df61bd79fc026108/test/cases/resolving/browser-field/index.js#L40-L43
Given
node_modules/recursive-file/package.json:{ "browser": { "a.js": "./a", "./b.js": "./b", "c.js": "./d.js", "./d.js": "./c.js" } }The following snippet should all throw recursion error.
Caveat:
require("module-c")should resolve to browser-module/node_modules/module-c.js givenhttps://github.com/oxc-project/oxc_resolver/blob/2baf418ab6f8c4cc5073d71dc9a628c43f1a0165/fixtures/enhanced_resolve/test/fixtures/browser-module/package.json#L7