这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 17, 2025

232 -> 144 bytes

part of #846

Copy link
Member Author

Boshen commented Nov 17, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.87%. Comparing base (f513bbd) to head (01d6be7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cache/cache_impl.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   93.90%   93.87%   -0.04%     
==========================================
  Files          17       17              
  Lines        3086     3084       -2     
==========================================
- Hits         2898     2895       -3     
- Misses        188      189       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Boshen Boshen force-pushed the 11-18-perf_remove_result_from_cachedpathimpl_canonicalized_ branch from ec222a7 to 01d6be7 Compare November 17, 2025 16:17
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #847 will improve performances by 3.79%

Comparing 11-18-perf_remove_result_from_cachedpathimpl_canonicalized_ (01d6be7) with main (f513bbd)

Summary

⚡ 1 improvement
✅ 10 untouched
⏩ 5 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
complex_real 23 µs 22.2 µs +3.79%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen merged commit 8e826e7 into main Nov 17, 2025
18 checks passed
@Boshen Boshen deleted the 11-18-perf_remove_result_from_cachedpathimpl_canonicalized_ branch November 17, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants