这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor: remove CachedPathImpl::canonicaling #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2025
Merged

refactor: remove CachedPathImpl::canonicaling #834

merged 1 commit into from
Nov 16, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 16, 2025

No description provided.

@Boshen Graphite App
Copy link
Member Author

Boshen commented Nov 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen mentioned this pull request Nov 16, 2025
Merged
@codecov
Copy link

codecov bot commented Nov 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.21%. Comparing base (424d9b9) to head (06c2c45).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/cache/cache_impl.rs 88.46% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   94.26%   94.21%   -0.05%     
==========================================
  Files          17       17              
  Lines        3068     3078      +10     
==========================================
+ Hits         2892     2900       +8     
- Misses        176      178       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #834 will improve performances by 4.91%

Comparing 11-16-refactor_remove_cachedpathimpl_canonicaling (06c2c45) with main (e9c472c)1

Summary

⚡ 2 improvements
✅ 9 untouched
⏩ 5 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ complex_real 23.4 µs 22.3 µs +4.91%
⚡ resolver_memory[multi-thread] 518 µs 502.2 µs +3.15%

Footnotes

  1. No successful run was found on main (06c2c45) during the generation of this report, so e9c472c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot added the merge label Nov 16, 2025
@graphite-app
Copy link

graphite-app bot commented Nov 16, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-16-refactor_remove_cachedpathimpl_canonicaling branch from 5c6f234 to 06c2c45 Compare November 16, 2025 09:27
@graphite-app graphite-app bot merged commit 06c2c45 into main Nov 16, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 11-16-refactor_remove_cachedpathimpl_canonicaling branch November 16, 2025 09:31
@graphite-app graphite-app bot removed the merge label Nov 16, 2025
This was referenced Nov 14, 2025
Open
Merged
graphite-app bot pushed a commit that referenced this pull request Nov 17, 2025
@Boshen
perf: cache canonicalization results at every recursion level (#843)
ff6e393 
Broke in #834

Moves path.canonicalized.get_or_init() from canonicalize_impl() into the recursive canonicalize_with_visited() function. This enables caching of parent directory canonicalization results, which are then reused when canonicalizing sibling paths.

Performance impact (measured with many example on monitor-oxc):
- Total filesystem syscalls: 124,071 → 39,296 (-68.3%)
- symlink_metadata calls: 99,169 → 17,503 (-82.4%)
- read_link calls: 6,127 → 3,018 (-50.7%)

The optimization is particularly effective for:
- Projects with deep node_modules structures
- pnpm workspaces (heavy symlink usage)
- Parallel resolution of multiple packages

All existing tests pass with no behavior changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen