这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor: remove a redundant path clone from PackageJson::parse #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

refactor: remove a redundant path clone from PackageJson::parse #725

merged 1 commit into from
Sep 23, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Sep 23, 2025

No description provided.

@graphite-app
Copy link

graphite-app bot commented Sep 23, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Boshen
Boshen commented Sep 23, 2025
View reviewed changes
@Boshen Boshen marked this pull request as draft September 23, 2025 08:01
@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.68%. Comparing base (5ed82ec) to head (e4821df).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   94.68%   94.68%   -0.01%     
==========================================
  Files          15       15              
  Lines        2899     2896       -3     
==========================================
- Hits         2745     2742       -3     
  Misses        154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 23, 2025

CodSpeed Performance Report

Merging #725 will not alter performance

Comparing 09-23-fix_memory_never_being_freed_with_a_self-referential_arc_clone (e4821df) with main (d9ad492)

Summary

✅ 7 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Boshen Boshen changed the title fix: memory never being freed with a self-referential Arc clone refactor: remove a redundant path clone from PackageJson::parse Sep 23, 2025
@Boshen Boshen marked this pull request as ready for review September 23, 2025 09:47
@Boshen Boshen merged commit e03b08a into main Sep 23, 2025
15 checks passed
@Boshen Boshen deleted the 09-23-fix_memory_never_being_freed_with_a_self-referential_arc_clone branch September 23, 2025 09:48
@Boshen Boshen mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen