Add string rewriting assists #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
oxalica
requested changes
Mar 10, 2023
Owner
oxalica
left a comment
There was a problem hiding this comment.
This PR is quite complicated. It would be better to split them into multiple small assists since they share no common code. Documentations can be added on individual fns. But they can still live in one mod.
About naming, my suggestion is to use the form rewrite_<from>_to_<to> for rewriting assists.
rewrite_uri_to_stringrewrite_string_to_indentedrewrite_indented_to_string
quote_attr and unquote_attr are okay to me.
Finally, don't forget to append to docs/code_actions.md.
oxalica
reviewed
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39 (comment)