Load configuration during initialize handling #84
Conversation
oxalica
left a comment
There was a problem hiding this comment.
initialization_options is for arbitrary user data. This loads the whole value and parse it as configuration. Is this a common practice? How do you pass initial configuration through this with LC-neovim?
Not sure if we should put configurations under another layer of indirection, like initialization_options.settings, for future-compatibility. Would it complicate the setup?
crates/nil/src/server.rs
Outdated
| }; | ||
|
|
||
| *Arc::get_mut(&mut self.config).expect("No concurrent access yet") = Config::new(root_path); | ||
| *Arc::get_mut(&mut self.config).expect("No concurrent access yet") = { |
There was a problem hiding this comment.
Please unwrap the block and move the Arc setting line below.
Allows to configure the server when client doesn't support `workspace/configuration` method, for example, LanguageClient-neovim.
YorikSar
left a comment
There was a problem hiding this comment.
initialization_optionsis for arbitrary user data. This loads the whole value and parse it as configuration. Is this a common practice? How do you pass initial configuration through this with LC-neovim?
LC-neovim allows to specify these options in global or workspace-specific config: https://github.com/autozimu/LanguageClient-neovim/blob/next/doc/LanguageClient.txt#L99-L112 and https://github.com/autozimu/LanguageClient-neovim/blob/next/doc/LanguageClient.txt#L289-L301. It seems it was intended to have workspace/configuration support, but that didn't happen yet.
Not sure if we should put configurations under another layer of indirection, like
initialization_options.settings, for future-compatibility. Would it complicate the setup?
Notice that examples in LanguageClient-neovim docs mention that these are the values that should be expected by workspace/configuration response. I assume that other language servers use same structure for both. For example, gopls uses the same function in initialize and workflow/configuration: https://github.com/golang/tools/blob/master/gopls/internal/lsp/general.go#L60 and https://github.com/golang/tools/blob/master/gopls/internal/lsp/general.go#L517. rust-analyzer loads config directly from that field as well: https://github.com/rust-lang/rust-analyzer/blob/master/crates/rust-analyzer/src/bin/main.rs#L189-L190
crates/nil/src/server.rs
Outdated
| }; | ||
|
|
||
| *Arc::get_mut(&mut self.config).expect("No concurrent access yet") = Config::new(root_path); | ||
| *Arc::get_mut(&mut self.config).expect("No concurrent access yet") = { |
04d67df to
c4eee44
Compare
|
Thanks! |
Allows to configure the server when client doesn't support
workspace/configurationmethod, for example, LanguageClient-neovim.