Enable nil diagnostics for multiple files
#126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what I am using in nixpkgs: Suboptimal? Yes. But it solves the problem. |
Contributor
Author
Sure. I don't think the fact that a workaround exists is a good reason to avoid making any improvements here, especially given how common a workflow this is and how many comparable tools support recursive file discovery. |
|
Assuming that we fixed the merge conflicts, is this PR acceptable in principle @oxalica? |
Owner
|
Manually merged with a few nit tweaks. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124.
This is the naive approach, which does not attempt to read files or compute diagnostics in parallel (unless there's some
salsamagic I don't understand happening under the hood).I was expecting this to be pretty slow, but on a codebase with 234 Nix files comprising 14,000 LOC,
nil diagnostics **/*.nixcompletes in 33ms. (Compare this toparallel --max-args 1 nil diagnostics ::: **/*.nix, which takes a full 4 seconds.)If we try
nil diagnostics **/*.nixinnixpkgs, we get:Which was to be expected. Using
findto executenil diagnosticswith as many arguments as possible (find . -path '*.nix' -exec nil diagnostics {} +) completes in just 6.5 seconds! (That's to analyze 32,800 files containing 3 million LOC.)The comparable command for one-invocation-per-file (
find . -path '*.nix' | parallel --pipe --cat -L 1 --max-args 1 nil diagnostics {}) takes... well, it's still running.