add follow method: local or global #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! While I like being able to configure this in Emacs, this behavior is already configurable in org-roam-ui (go to behavior and then to "Follow Emacs by..."), and changing this behavior in Emacs would not automatically change what that option does (it wouldn't do anything). Does that option work for you? We plan to have all of the options in the UI configurable in Emacs anyway, so I feel like having this specific option toggleable in Emacs at this time will lead to confusion down the road, as we would either have to remove it or have it be separate to the rest of the configuration, neither of which sound ideal to me. What do you think? Also, thanks for spotting the typo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I have 1w+ nodes, follow emacs in a global graph is low performance and not very useful.
I add a new variable
org-roam-ui-follow-method.If this is set to
global, it behaves like before;If this is set to
local, it will auto open the corresponding local graph of current node.