这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix memleaks in cmd_RecordPadding() #25926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix memleaks in cmd_RecordPadding() #25926

wants to merge 1 commit into from

Conversation

@holger-dengler
Copy link
Contributor

@holger-dengler holger-dengler commented Nov 11, 2024

Free the internal copy of parameter value on each early exit.

Fixes #25906

Checklist
  • documentation is added or updated
  • tests are added or updated

@holger-dengler
Fix memleaks in cmd_RecordPadding()
5e04418 
Free the internal copy of parameter `value` on each early
exit.

Fixes openssl#25906

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
@holger-dengler holger-dengler changed the title Fix memleak in cmd_RecordPadding() Fix memleaks in cmd_RecordPadding() Nov 11, 2024
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 labels Nov 11, 2024
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 11, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 12, 2024
@openssl-machine
Copy link
Collaborator

openssl-machine commented Nov 12, 2024

This pull request is ready to merge

shahsb
shahsb approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@shahsb shahsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t8m t8m removed branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels Nov 13, 2024
@t8m
Copy link
Member

t8m commented Nov 13, 2024

Merged to the master and 3.4 branches. The leak is not present in earlier branches. Thank you for your contribution.

@t8m t8m closed this Nov 13, 2024
openssl-machine pushed a commit that referenced this pull request Nov 13, 2024
@holger-dengler @t8m
Fix memleaks in cmd_RecordPadding()
4393fdd 
Free the internal copy of parameter `value` on each early
exit.

Fixes #25906

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #25926)

(cherry picked from commit 0abbd3e)
openssl-machine pushed a commit that referenced this pull request Nov 13, 2024
@holger-dengler @t8m
Fix memleaks in cmd_RecordPadding()
0abbd3e 
Free the internal copy of parameter `value` on each early
exit.

Fixes #25906

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #25926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

+1 more reviewer

@shahsb shahsb shahsb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.4 Merge to openssl-3.4 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There is a memory leak defect at line 678 in the file /openssl/ssl/ssl_conf.c.

5 participants

@holger-dengler @openssl-machine @t8m @mattcaswell @shahsb