Fix memleak in dsa_gen() #25948
Closed
Fix memleak in dsa_gen() #25948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Free the stack return value `dsa` on each early exit. Fixes openssl#25905 Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
kroeckx
approved these changes
Nov 14, 2024
shahsb
approved these changes
Nov 14, 2024
Contributor
shahsb
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes!
Sashan
approved these changes
Nov 15, 2024
Contributor
Sashan
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
t8m
approved these changes
Nov 15, 2024
Collaborator
|
This pull request is ready to merge |
Member
|
Merged to the master, 3.4 and 3.3 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 29, 2024
Free the stack return value `dsa` on each early exit. Fixes #25905 Signed-off-by: Holger Dengler <dengler@linux.ibm.com> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #25948) (cherry picked from commit f4550fb)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 29, 2024
Free the stack return value `dsa` on each early exit. Fixes #25905 Signed-off-by: Holger Dengler <dengler@linux.ibm.com> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #25948) (cherry picked from commit f4550fb)
Sashan
pushed a commit
to Sashan/openssl
that referenced
this pull request
Apr 23, 2025
Free the stack return value `dsa` on each early exit. Fixes openssl#25905 Signed-off-by: Holger Dengler <dengler@linux.ibm.com> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#25948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free the stack return value
dsaon each early exit.Fixes #25905
Checklist