Fix a build failure where recvmmsg is available but not sendmmsg #22036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some old glibc versions have recvmmsg but not sendmmsg. We require both to use that functionality. Introduce a test to check we have a sufficiently recent version of glibc. Fixes openssl#22021
nhorman
reviewed
Sep 8, 2023
|
|
||
| # if defined(__GLIBC__) && defined(__GLIBC_PREREQ) | ||
| # if !(__GLIBC_PREREQ(2, 14)) | ||
| # undef NO_RECVMMSG |
Contributor
There was a problem hiding this comment.
why the undef here? Its just going to get reset on line 61, no?
Member
Author
There was a problem hiding this comment.
To avoid the compiler complaining about it being redefined in the event it is already defined e.g. because OpenSSL was configured like this:
$ ./config -DNO_RECVMMSG
t8m
approved these changes
Sep 8, 2023
hlandau
approved these changes
Sep 8, 2023
t-j-h
approved these changes
Sep 9, 2023
Collaborator
|
This pull request is ready to merge |
Member
|
Merged to master. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 11, 2023
Some old glibc versions have recvmmsg but not sendmmsg. We require both to use that functionality. Introduce a test to check we have a sufficiently recent version of glibc. Fixes #22021 Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #22036)
Member
Author
|
@rainerjung confirmed this as working on the affected platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old glibc versions have recvmmsg but not sendmmsg. We require both to use that functionality. Introduce a test to check we have a sufficiently recent version of glibc.
Fixes #22021