Attempt to restrict XSS filtering #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Will this prevent someone from submitting stored XSS via our REST calls? |
Member
Author
|
In so far as they work on form parameters, it will. We need a slightly different solution for the REST API, though, as HTML-encoding will break anything where we expect the client to submit XML since, e.g., Becomes which won’t be parsed correctly. Basically for REST, we need to HTML encode the values as they are deserialised. |
|
Hey! Just a small suggestion: I didn’t see any new or updated tests for this. Adding test coverage to check the filter behavior on form vs. non-form requests might help catch issues in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to limit the application of the XSS filter.