Fix search data showing null #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Sep 30, 2024
| var cols = this.options.fieldsAndHeaders; | ||
| rRowData = $j.map(cols, function(c) { | ||
| var data = rowData[c.fieldName]; | ||
| if(data == null) |
Member
There was a problem hiding this comment.
Have you looked into why we did not have this problem originally without this change?
Member
Author
There was a problem hiding this comment.
Now we return null as a string. I am not sure where we made that change though.
Member
There was a problem hiding this comment.
Can you try to locate where we made that change?
Member
Author
There was a problem hiding this comment.
This is what is causing the issue:
WebUtil.escapeHTML() converts null to a string.
This was introduced here: https://github.com/openmrs/openmrs-module-legacyui/pull/191/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.