这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@slubwama
Copy link
Contributor

@slubwama slubwama commented Oct 9, 2024

No description provided.

@slubwama slubwama requested a review from dkayiwa October 9, 2024 11:03
</c:choose>

<input type="hidden" name="refererURL" value='<request:header name="referer" />' />
<input type="hidden" name="refererURL" value='<c:out value="${pageContext.request.getHeader('referer')}"/>' />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the XSS attack came via the referer param?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@ibacher
Copy link
Member

ibacher commented Oct 9, 2024

Could we also do the same for this one:

<input type="hidden" name="redirectURL" value='<request:header name="referer" />' />

@slubwama
Copy link
Contributor Author

slubwama commented Oct 9, 2024

Could we also do the same for this one:

<input type="hidden" name="redirectURL" value='<request:header name="referer" />' />

Done

@dkayiwa dkayiwa merged commit d111cdf into openmrs:master Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants