RA-1865: Fix XSS in Add Encounter to Visit #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
@isears
Fixed
DWREncounterService.javato encode the search result phrase that appears when users search for an encounter to add in theEdit Visitpage.Note: Since
uiwas not defined in this file, I modeled this fix after this PR.Link to Ticket
https://issues.openmrs.org/browse/RA-1865
Issue I worked on
This fix protects against reflected XSS that is executed when a user searches for an encounter to add on the Edit Visit page. Specifically, this vulnerability fixes the vulnerability that occurs when no search results match the search phrase. The search widget that appears presents a message which reads "No matches found for {search phrase}", which reflects XSS in the search phrase.
Before Fix
Injected iframe appears in search message:

After Fix
Search message is now shown as text rather than interpreted as HTML:

Steps to reproduce
An iframe will appear in the search result.