Empt75 - Manage privileges susceptible to XSS #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid any XSS attacks on error div
Contributor
@jmmacdo4 are you still working on this mess |
Member
|
Oh, I see. I by mistake closed #136 because I assumed this superseded it. I'll go ahead and reopen it. It definitely makes sense to keep these two issues separate. First glance at the |
Contributor
Author
|
This PR has been restructured and reopened as #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever
ListPickerTag.javais used, the individual items could contain HTML XSS that could be embedded on the page. By sanitizing them using HTML encoding, they no longer allow XSS attacks such as iframes.@isears I am currently trying to untangle the git mess I made with this one (I didn't make a new branch for the error div vulnerability we talked about last week). The only change that should be in this PR is in
ListPickerTag.java. I just wanted to get it up for review ASAP since our meeting is tomorrow.