这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jdegraft
Copy link
Contributor

Migrated Legacy Maintenance Admin

Migrated Legacy Maintenance Admin
dkayiwa added a commit that referenced this pull request Oct 28, 2015
@dkayiwa dkayiwa merged commit 619eb64 into openmrs:master Oct 28, 2015
@jdegraft
Copy link
Contributor Author

Yes, I have fixed the line wrapping issue. Turned off auto format on save.

@dkayiwa
Copy link
Member

dkayiwa commented Oct 28, 2015

@jdegraft are you making a pull another commit to reverse the earlier formatting?

@jdegraft
Copy link
Contributor Author

@dkayiwa , frankly, I don't know how to go about it.
Wouldn't it be a better idea to setup formatting as part of the build process as it is done in core?

@lluismf
Copy link

lluismf commented Oct 29, 2015

Probably, but there's no agreement on which is the limit (if any). There's
a discussion here
https://talk.openmrs.org/t/openmrs-code-formatter-styles/794/9

2015-10-29 0:48 GMT+01:00 jdegraft notifications@github.com:

Frankly, I don't know how to go about it.
Wouldn't it be a better idea to setup formatting as part of the build
process as it is done in core?


Reply to this email directly or view it on GitHub
#10 (comment)
.

@jdegraft
Copy link
Contributor Author

@lluismf Thanks, I have set it to 120. I will update files and create pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants