Add packaging unit in dispensing app #117
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
approved these changes
Aug 21, 2024
Member
mogoodrich
left a comment
There was a problem hiding this comment.
I'm defer to others with stock management module experience about the details, but generally LGTM!
|
@gabriel090 - kindly link this to a ticket and provide a screenshot/video for the change. |
ojwanganto
reviewed
Aug 21, 2024
| return t( | ||
| 'stockDispenseDetails', | ||
| 'Batch: {{batchNumber}} - Quantity: {{quantity}} ({{quantityUoM}}) - Expiry: {{expiration}}', | ||
| 'Batch: {{batchNumber}} - Quantity: {{quantity}} - Expiry: {{expiration}} - Packaging Size: ({{quantityUoM}})-{{quantityFactor}}', |
There was a problem hiding this comment.
Alternatively, we can use the 'Pack size' short name or just Pack.
|
Thanks, @gabriel090. Please add a screenshot and ticket for this work. |
Contributor
|
@ojwanganto Would you mind kindly taking a moment to review the changes captured in this PR, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Add packing name in dispensing app.
Screenshots
dispense.mp4
Related Issue
Other