这是indexloc提供的服务,不要输入任何密码
Skip to content

Custom Tabs was first added in Samsung Internet 4.0 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

hnljp
Copy link
Contributor

@hnljp hnljp commented Jul 20, 2018

At the moment all versions of the Samsung Internet Browser is set to support Custom Tabs. Support for Custom Tabs was first added in version 4.0.

fixes: #382
Signed-off-by: Henning Nielsen Lund henning.n.lund@jp.dk

hnljp added 3 commits July 21, 2018 00:57
At the moment all versions of the Samsung Internet Browser is set to support Custom Tabs. Support for Custom Tabs was first added in version 4.0.

fixes: openid#382
Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk>
At the moment all versions of the Samsung Internet Browser is set to support Custom Tabs. Support for Custom Tabs was first added in version 4.0.

fixes: openid#382
Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk>
At the moment all versions of the Samsung Internet Browser is set to support Custom Tabs. Support for Custom Tabs was first added in version 4.0.

fixes: openid#382

fixed indentation

Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk>
@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #383 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
+ Coverage     82.93%   82.96%   +0.02%     
  Complexity      456      456              
============================================
  Files            41       41              
  Lines          2233     2236       +3     
  Branches        217      217              
============================================
+ Hits           1852     1855       +3     
  Misses          298      298              
  Partials         83       83
Impacted Files Coverage Δ Complexity Δ
...penid/appauth/browser/VersionedBrowserMatcher.java 85% <100%> (+0.78%) 7 <0> (ø) ⬇️
...rary/java/net/openid/appauth/browser/Browsers.java 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c5b26...4e20e18. Read the comment docs.

@hnljp
Copy link
Contributor Author

hnljp commented Jul 28, 2018

Documentation:
From the release notes:

Samsung Internet for Android 4.0

Secret Mode
Content Cards
Floating Video
Video History
Web Push
Service Workers
Custom Tabs
Content Blocker Extension
Web Engine is upgraded to Chromium 44.2403

@iainmcgin
Copy link
Member

Thanks!

@iainmcgin iainmcgin merged commit aa8c507 into openid:master Aug 7, 2018
@hnljp hnljp deleted the SBrowser-min_version branch August 7, 2018 19:14
athilahs added a commit to Skyscanner/AppAuth-Android that referenced this pull request Aug 17, 2020
* Minor README fixes (openid#351)

Thanks to @celphy for spotting these mistakes.

* Add WeWork to AUTHORS

WeWork, as my employer, is now the copyright owner for my
contributions to AppAuth.

* Dependency version bump

* Handle CustomTabsSession.newSession failures

Fixes openid#315.

* Enable Java 8 language features

* Do not automatically pass scope on token exchange request

Fixes openid#297.

* Do not override tab title setting

Fixes openid#358.

* Firefox customtabs (openid#378)

Add support for custom tabs in Firefox. Support for custom tabs was added to stable Firefox in version 57.0

Fixes: openid#368
Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk>

* Respect default browser of the user (openid#379)

Correctly orders the user's preferred browser to the start of the returned list.

* Custom Tabs was first added in Samsung Internet 4.0 (openid#383)

At the moment all versions of the Samsung Internet Browser is set to support Custom Tabs. Support for Custom Tabs was first added in version 4.0.

fixes: openid#382

* add getBrowserDescriptor() (openid#388)

Make it possible to get the BrowserDescriptor used by AuthorizationService.

fixes: openid#387
Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk>

* Android gradle plugin version bump

* Implement ID Token validation according to OIDC spec (openid#385)

Validate ID Tokens (if any) on TokenResponses according to http://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation

* Add Øyvind to the contributors list

* Update CONTRIBUTORS with email (openid#397)

* Use CustomTabsService.ACTION_CUSTOM_TABS_CONNECTION in BrowserSelector. (openid#411)

* This helps with the jetification. I produced an artifact locally,
  and wrote a sample app using:

  ```gradle
  implementation 'androidx.appcompat:appcompat:1.0.0-rc02'
  implementation 'androidx.browser:browser:1.0.0-rc02'
  ```

  to make sure that the app works.

Fixes: openid#395

* Issue openid#402: fixes NPE in case input stream is null (openid#414)

* Fix spelling mistake

* Update link to custom tabs documentation

* Fix typo in README.md (openid#455)

* Fix `Using access tokens` snippet in the readme (openid#510)

The snippet code in the `Using access tokens` section didn't follow java code formatting.

* Use capitalized form for "Bearer" token type

While this is case-insensitive, some provider implementations do not correctly handle the lower case form.

* Migrate to AndroidX & Update dependencies (openid#508)

* gradle update to 5.4.1

* gradle plugin update to 3.5.3

* minor bintray update

* bump compile sdk to 29

- this requires bumping build tools to 29
- also updating the gradlewrapper (again, fully) to 5.4.1

* Migrate to AndroidX

This required changes to checkstyle & javadocs gradle files
(perhaps because of jetifier? not sure tbh)
Also mockito now can mock all final classes

* Fix compiler warning

* update travis build tools to 29.0.2 to align with build.gradle

* update travis android sdk version to 29 to align with build.gradle

* Android11 support (openid#558)

- Migrated from the deprecated Android Support libraries to the newest versions of the AndroidX libraries.
- The Android gradle plugin is updated to the current 4.0.0.
- Glide is updated to the current 4.11.0, and 4.1x.x is needed for AndroidX support.
- limit the allowed queries to only fullbrowsers - openid#554 .
- Add support for CATEGORY_APP_BROWSER.
- Update dependencies

* Deprecate whitelist and blacklist (openid#555)

* Replace BrowserBlacklist with BrowserDenyList and BrowserWhitelist with BrowserAllowList

* Add xmlpull library dependency for tests because some of the unit tests fail without it.

* Override constructors and add a deprecation migration test

* Update library version to 0.8.0-skyscanner

* Fix build after upgrading gradle plugin (as result of syncing up with openid repo)

Co-authored-by: Iain McGinniss <iainmcgin@gmail.com>
Co-authored-by: Iain McGinniss <iain.mcginniss@wework.com>
Co-authored-by: Henning Lund <40355805+hnljp@users.noreply.github.com>
Co-authored-by: Øyvind Robertsen <oyvindrobertsen@gmail.com>
Co-authored-by: Rahul Ravikumar <tikurahul@users.noreply.github.com>
Co-authored-by: Thomas Rebouillon <thomas.rebouillon@gmail.com>
Co-authored-by: Mark Kowalski <mark.kowalski86@googlemail.com>
Co-authored-by: Ahmad El-Melegy <ahmad.melegy@gmail.com>
Co-authored-by: Paul Blundell <blundell.app.dev@gmail.com>
Co-authored-by: Jon F Hancock <jonfhancock@gmail.com>
Co-authored-by: Athila Santos <athilahs>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Custom Tabs was first added in Samsung Internet 4.0
4 participants